fix: 🐛 Support 'overrideConfigFile' option for ESLint #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #745 +/- ##
==========================================
+ Coverage 99.65% 99.66% +0.01%
==========================================
Files 2 2
Lines 287 298 +11
Branches 78 88 +10
==========================================
+ Hits 286 297 +11
Misses 1 1
Continue to review full report at Codecov.
|
idahogurl
commented
May 10, 2022
Comment on lines
-99
to
-101
| baseConfig: { | ||
| settings: eslintConfig.settings || {} | ||
| }, |
There was a problem hiding this comment.
settings will be in the overrideConfig option
zimme
approved these changes
May 10, 2022
kylemh
approved these changes
May 10, 2022
|
🎉 This PR is included in version 14.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option of
overrideConfigFiledoes not work because the optionoverrideConfig, according to the documentation, is applied afteroverrideConfigFileapplied. The values fromcalculateConfigForFileare placed in theoverrideConfigFileoption thus overriding the rules obtained from theoverrideConfigFile. To fix this, we need to passoverrideConfigFileand other pertinent options to the ESLint instance so whencalculateConfigForFileis called then it generates the correct config values.